Open
Conversation
- Remove unused pre-load link in index.html to resolve runtime warnings - Remove unused hero image asset from repo
- Remove unused, undefined vars ('showAll', 'smallScreens') in Research Tech
- Variables were unapplicable since 'items2' array was too small (length = 3)
but UI logic checked for length between 4-8 items
- Remove unused Tailwind transition classes
jschhie
added
bug
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jschhie
commented
Mar 23, 2026
| id="div_about_us" | ||
| class="flex flex-wrap justify-center gap-6 mt-[40px] tablet:mt-[72px] mb-[32px] w-full transition-all duration-500 ease-in-out" | ||
| > | ||
| <div |
Collaborator
Author
There was a problem hiding this comment.
- Before: Inapplicable UI logic/Tailwind classes since
items2array length is 3, but template checks for 4-8 items - After: Removed undefined variables (
showAll,smallScreen) to resolve access warnings and correctly reflect UI logic
(Initial
:classrules appear to be copied fromPressList.vue. See below)
`PressList.vue` snippet for reference
<!--- (PressList.vue) -->
<div
v-for="(item, index) in displayedItems"
:key="index"
class="flex animate-fade-slide-in"
:class="{
'opacity-0 translate-y-4':
(smallScreen ? index >= 4 : index >= 8) && !showAll,
'opacity-100 translate-y-0':
showAll || (smallScreen ? index < 4 : index < 8),
}"
>
jschhie
commented
Mar 23, 2026
|
|
||
| <script defer type="module" src="/src/main.js"></script> | ||
|
|
||
| <link |
Collaborator
Author
There was a problem hiding this comment.
(Refactored for sitewide performance; see inline docs in modified src/pages/Home/Hero/Hero.vue)
- Set empty alt text for decorative img tags
- Remove preload link in 'index.html' script (triggered sitewide console warnings) - Add matching preload link in onMounted() for <Hero/> (Home Page) - Improve performance sitewide, reduce extra preloaded image assets
jschhie
force-pushed
the
fix/console-runtime-warnings-sitewide
branch
from
feccf7d to
4e97ea7
Compare
jschhie
added
the
chore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
alttext on decorative assetsApproach
preloadlinks from sharedindex.htmlinto<Hero/>logic onlyOurProjects/Hero.vue& remove unused importsundefinedvariables (showAll,smallScreen)Screenshots: Resolved Warnings
1. Sitewide: Unused
preloadlink2. Chrome DevTools: Network Logs
hero-illustration.png, a blue geometric shape); only Home page loads actual Hero image (hero-resized.png, Carl mascot)mainbranch (Sampled from "Team" Page)3. Impact Page: Access to
undefinedvariablesManual Tests
Priority: u=1, i)Future Work